lan/HMCL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

优化 ModTranslations::loadFromResource (#4178)

Browse Source
This commit is contained in:
Glavo
2025-08-04 20:31:29 +08:00
committed by GitHub
parent bb3d03fc72
commit 0a1d6be7b7
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModTranslations.java
View File

@@ -20,9 +20,11 @@ package org.jackhuang.hmcl.ui.versions;
import org.jackhuang.hmcl.mod.RemoteModRepository; import org.jackhuang.hmcl.mod.RemoteModRepository;
import org.jackhuang.hmcl.util.Pair; import org.jackhuang.hmcl.util.Pair;
import org.jackhuang.hmcl.util.StringUtils; import org.jackhuang.hmcl.util.StringUtils;
import org.jackhuang.hmcl.util.io.IOUtils;
import org.jetbrains.annotations.Nullable; import org.jetbrains.annotations.Nullable;
import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.nio.charset.StandardCharsets;
import java.util.*; import java.util.*;
import java.util.stream.Collectors; import java.util.stream.Collectors;
@@ -121,9 +123,11 @@ public enum ModTranslations {
return true; return true;
} }
try { //noinspection DataFlowIssue
String modData = IOUtils.readFullyAsString(ModTranslations.class.getResourceAsStream(resourceName)); try (BufferedReader reader = new BufferedReader(
mods = Arrays.stream(modData.split("\n")).filter(line -> !line.startsWith("#")).map(Mod::new).collect(Collectors.toList()); new InputStreamReader(
ModTranslations.class.getResourceAsStream(resourceName), StandardCharsets.UTF_8))) {
mods = reader.lines().filter(line -> !line.startsWith("#")).map(Mod::new).collect(Collectors.toList());
return true; return true;
} catch (Exception e) { } catch (Exception e) {
LOG.warning("Failed to load " + resourceName, e); LOG.warning("Failed to load " + resourceName, e);