From 0a7c32b3cb47abd71358188570ec247120e5f675 Mon Sep 17 00:00:00 2001 From: huangyuhui Date: Sat, 18 Aug 2018 22:40:08 +0800 Subject: [PATCH] Friendly prompt warning user about independent version deletion --- HMCL/src/main/java/org/jackhuang/hmcl/ui/VersionPage.java | 4 +++- HMCL/src/main/resources/assets/lang/I18N.properties | 3 ++- HMCL/src/main/resources/assets/lang/I18N_zh.properties | 1 + HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties | 1 + 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/VersionPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/VersionPage.java index 953ea1c2b..32575afcf 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/VersionPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/VersionPage.java @@ -28,6 +28,7 @@ import javafx.scene.control.Tab; import javafx.scene.layout.StackPane; import org.jackhuang.hmcl.download.game.GameAssetIndexDownloadTask; +import org.jackhuang.hmcl.setting.EnumGameDirectory; import org.jackhuang.hmcl.setting.Profile; import org.jackhuang.hmcl.ui.export.ExportWizardProvider; import org.jackhuang.hmcl.ui.wizard.DecoratorPage; @@ -186,7 +187,8 @@ public final class VersionPage extends StackPane implements DecoratorPage { } public static void deleteVersion(Profile profile, String version) { - Controllers.confirmDialog(i18n("version.manage.remove.confirm", version), i18n("message.confirm"), () -> { + boolean isIndependent = profile.getVersionSetting(version).getGameDirType() == EnumGameDirectory.VERSION_FOLDER; + Controllers.confirmDialog(i18n(isIndependent ? "version.manage.remove.confirm.independent" : "version.manage.remove.confirm", version), i18n("message.confirm"), () -> { if (profile.getRepository().removeVersionFromDisk(version)) { profile.getRepository().refreshVersionsAsync().start(); Controllers.navigate(null); diff --git a/HMCL/src/main/resources/assets/lang/I18N.properties b/HMCL/src/main/resources/assets/lang/I18N.properties index 94ec5e947..b2c53ea70 100644 --- a/HMCL/src/main/resources/assets/lang/I18N.properties +++ b/HMCL/src/main/resources/assets/lang/I18N.properties @@ -334,7 +334,8 @@ version.launch_script.save=Save the launch script version.launch_script.success=Finished script creation, %s. version.manage.redownload_assets_index=Redownload Assets Index version.manage.remove=Delete this game -version.manage.remove.confirm=Sure to remove version %s? +version.manage.remove.confirm=Sure to remove game %s? +version.manage.remove.confirm.independent=Since this game is in independent mode, deleting this game will result in all saved worlds belonging to this game removed simultaneously. Sure to remove game %s? version.manage.remove_libraries=Delete library files version.manage.rename=Rename this game version.manage.rename.message=Please enter the new name diff --git a/HMCL/src/main/resources/assets/lang/I18N_zh.properties b/HMCL/src/main/resources/assets/lang/I18N_zh.properties index e8f8920d0..48718bce0 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_zh.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_zh.properties @@ -335,6 +335,7 @@ version.launch_script.success=啓動腳本已生成完畢：%s version.manage.redownload_assets_index=重新下載資源配置（assets_index.json） version.manage.remove=刪除該版本 version.manage.remove.confirm=真的要刪除版本 %s 嗎？ +version.manage.remove.confirm.independent=由於該遊戲使用了版本隔離，所以刪除該版本將導致該遊戲的存檔等數據一同被刪除，真的要刪除版本 %s 嗎？ version.manage.remove_libraries=刪除所有庫文件 version.manage.rename=重命名該版本 version.manage.rename.message=請輸入要改成的名字 diff --git a/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties b/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties index 93189b0f3..441aeb07b 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties @@ -335,6 +335,7 @@ version.launch_script.success=启动脚本已生成完毕：%s version.manage.redownload_assets_index=重新下载资源配置（assets_index.json） version.manage.remove=删除该版本 version.manage.remove.confirm=真的要删除版本 %s 吗？ +version.manage.remove.confirm.independent=由于该游戏使用了版本隔离，所以删除该版本将导致该游戏的存档等数据一同被删除，真的要删除版本 %s 吗？ version.manage.remove_libraries=删除所有库文件 version.manage.rename=重命名该版本 version.manage.rename.message=请输入要改成的名字