From 2b9f0702798e8876742fe9fc28a9169778fa4589 Mon Sep 17 00:00:00 2001 From: huanghongxun Date: Tue, 10 Mar 2020 17:50:25 +0800 Subject: [PATCH] fix: #683 --- .../java/org/jackhuang/hmcl/game/VersionLibraryBuilder.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/HMCLCore/src/main/java/org/jackhuang/hmcl/game/VersionLibraryBuilder.java b/HMCLCore/src/main/java/org/jackhuang/hmcl/game/VersionLibraryBuilder.java index f8f3e0ee2..275944f3d 100644 --- a/HMCLCore/src/main/java/org/jackhuang/hmcl/game/VersionLibraryBuilder.java +++ b/HMCLCore/src/main/java/org/jackhuang/hmcl/game/VersionLibraryBuilder.java @@ -51,7 +51,7 @@ public final class VersionLibraryBuilder { } public void removeTweakClass(String target) { - replaceTweakClass(target, null, true); + replaceTweakClass(target, null, false); } /** @@ -86,6 +86,9 @@ public final class VersionLibraryBuilder { * @param inPlace if true, replace the tweak class in place, otherwise add the tweak class to the end of the argument list without replacement. */ public void replaceTweakClass(String target, String replacement, boolean inPlace) { + if (replacement == null && inPlace) + throw new IllegalArgumentException("Replacement cannot be null in replace mode"); + boolean replaced = false; if (useMcArgs) { for (int i = 0; i + 1 < mcArgs.size(); ++i) {