lan/HMCL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix #4256: 修复游戏下载页面可能崩溃的问题 (#4257)

Browse Source
This commit is contained in:
Glavo
2025-08-13 16:14:26 +08:00
committed by GitHub
parent a705b7cf95
commit 5118ce4e62
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
HMCL/src/main/java/org/jackhuang/hmcl/ui/download/VersionsPage.java
View File

@@ -74,7 +74,6 @@ public final class VersionsPage extends Control implements WizardPage, Refreshab
private final Navigation navigation; private final Navigation navigation;
private final VersionList<?> versionList; private final VersionList<?> versionList;
private final Runnable callback; private final Runnable callback;
private Task<?> task;
private final ObservableList<RemoteVersion> versions = FXCollections.observableArrayList(); private final ObservableList<RemoteVersion> versions = FXCollections.observableArrayList();
private final ObjectProperty<Status> status = new SimpleObjectProperty<>(Status.LOADING); private final ObjectProperty<Status> status = new SimpleObjectProperty<>(Status.LOADING);
@@ -98,7 +97,7 @@ public final class VersionsPage extends Control implements WizardPage, Refreshab
@Override @Override
public void refresh() { public void refresh() {
status.set(Status.LOADING); status.set(Status.LOADING);
task = versionList.refreshAsync(gameVersion) Task<?> task = versionList.refreshAsync(gameVersion)
.thenSupplyAsync(() -> versionList.getVersions(gameVersion).stream().sorted().collect(Collectors.toList())) .thenSupplyAsync(() -> versionList.getVersions(gameVersion).stream().sorted().collect(Collectors.toList()))
.whenComplete(Schedulers.javafx(), (items, exception) -> { .whenComplete(Schedulers.javafx(), (items, exception) -> {
if (exception == null) { if (exception == null) {
@@ -120,8 +119,6 @@ public final class VersionsPage extends Control implements WizardPage, Refreshab
@Override @Override
public void cleanup(Map<String, Object> settings) { public void cleanup(Map<String, Object> settings) {
settings.remove(libraryId); settings.remove(libraryId);
if (task != null)
task.executor().cancel();
} }
private void onRefresh() { private void onRefresh() {