From 57554c8d4bcd6357c901fc1818611bfb6066d8d2 Mon Sep 17 00:00:00 2001 From: huanghongxun Date: Wed, 20 Oct 2021 15:49:16 +0800 Subject: [PATCH] fix(ui): validate background image url. Mentioned in #1116. --- .../java/org/jackhuang/hmcl/ui/construct/MultiFileItem.java | 5 +++++ .../java/org/jackhuang/hmcl/ui/main/PersonalizationPage.java | 1 + 2 files changed, 6 insertions(+) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MultiFileItem.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MultiFileItem.java index cd15677c5..7b2822f32 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MultiFileItem.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MultiFileItem.java @@ -226,6 +226,11 @@ public class MultiFileItem extends VBox { BorderPane.setAlignment(customField, Pos.CENTER_RIGHT); customField.disableProperty().bind(left.selectedProperty().not()); + + if (!customField.getValidators().isEmpty()) { + FXUtils.setValidateWhileTextChanged(customField, true); + } + pane.setRight(customField); return pane; diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/PersonalizationPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/PersonalizationPage.java index 71f8ed3c3..8544953e0 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/PersonalizationPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/main/PersonalizationPage.java @@ -107,6 +107,7 @@ public class PersonalizationPage extends StackPane { .setChooserTitle(i18n("launcher.background.choose")) .bindBidirectional(config().backgroundImageProperty()), new MultiFileItem.StringOption<>(i18n("launcher.background.network"), EnumBackgroundImage.NETWORK) + .setValidators(new URLValidator(true)) .bindBidirectional(config().backgroundImageUrlProperty()) )); backgroundItem.selectedDataProperty().bindBidirectional(config().backgroundImageTypeProperty());