修复自动安装在 1.20.4 的严重问题 (#3023)

* Fix: OptiFine and Forge has compatible problem on 1.20.4 . Fix: Forge changes it's main class on 1.20.4 .

* Fix: HMCL cannot display the analyed versions installed by external launchers.

* Refuse to configure installable widgets when it's from external process.

* Add javadoc about LibraryStatus

* Adapt to the new change of Forge: b8270cd9ff

* Re-arrange entries.

* Fix.

HMCL/src/main/java/org/jackhuang/hmcl/ui/InstallerItem.java

@@ -270,10 +270,12 @@ public class InstallerItem extends Control {
                     return i18n("install.installer.incompatible", i18n("install.installer." + incompatibleWith));
                 } else if (version == null) {
                     return i18n("install.installer.not_installed");
-                } else {
+                } else if (control.id.equals(MINECRAFT.getPatchId()) || control.removable.get() || control.upgradable.get()) {
                     return i18n("install.installer.version", version);
+                } else {
+                    return i18n("install.installer.external_version", version);
                 }
-            }, control.incompatibleLibraryName, control.incompatibleWithGame, control.libraryVersion));
+            }, control.incompatibleLibraryName, control.incompatibleWithGame, control.libraryVersion, control.installable, control.removable, control.upgradable));
             BorderPane.setMargin(statusLabel, new Insets(0, 0, 0, 8));
             BorderPane.setAlignment(statusLabel, Pos.CENTER_LEFT);
 
@@ -297,8 +299,9 @@ public class InstallerItem extends Control {
                     control.upgradable));
             arrowButton.getStyleClass().add("toggle-icon4");
             arrowButton.visibleProperty().bind(Bindings.createBooleanBinding(
-                    () -> control.installable.get() && control.incompatibleLibraryName.get() == null,
-                    control.installable, control.incompatibleLibraryName));
+                    () -> control.installable.get() && control.libraryVersion.get() == null && control.incompatibleLibraryName.get() == null,
+                    control.installable, control.libraryVersion, control.incompatibleLibraryName
+            ));
             arrowButton.managedProperty().bind(arrowButton.visibleProperty());
             arrowButton.onMouseClickedProperty().bind(control.action);
             buttonsContainer.getChildren().add(arrowButton);

HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/InstallerListPage.java

@@ -30,7 +30,6 @@ import org.jackhuang.hmcl.task.TaskExecutor;
 import org.jackhuang.hmcl.task.TaskListener;
 import org.jackhuang.hmcl.ui.*;
 import org.jackhuang.hmcl.ui.download.UpdateInstallerWizardProvider;
-import org.jackhuang.hmcl.util.Lang;
 import org.jackhuang.hmcl.util.TaskCancellationAction;
 import org.jackhuang.hmcl.util.io.FileUtils;
 
@@ -90,13 +89,15 @@ public class InstallerListPage extends ListPageBase<InstallerItem> implements Ve
             for (InstallerItem installerItem : group.getLibraries()) {
                 String libraryId = installerItem.getLibraryId();
                 String libraryVersion = analyzer.getVersion(libraryId).orElse(null);
+                boolean libraryConfigurable = libraryVersion != null && analyzer.getLibraryStatus(libraryId) == LibraryAnalyzer.LibraryMark.LibraryStatus.CLEAR;
+
                 installerItem.libraryVersion.set(libraryVersion);
-                installerItem.upgradable.set(libraryVersion != null);
+                installerItem.upgradable.set(libraryConfigurable);
                 installerItem.installable.set(true);
                 installerItem.action.set(e -> {
                     Controllers.getDecorator().startWizard(new UpdateInstallerWizardProvider(profile, gameVersion, version, libraryId, libraryVersion));
                 });
-                boolean removable = !LibraryAnalyzer.LibraryType.MINECRAFT.getPatchId().equals(libraryId) && libraryVersion != null;
+                boolean removable = !LibraryAnalyzer.LibraryType.MINECRAFT.getPatchId().equals(libraryId) && libraryConfigurable;
                 installerItem.removable.set(removable);
                 if (removable) {
                     Runnable action = removeAction.apply(libraryId);
@@ -119,17 +120,10 @@ public class InstallerListPage extends ListPageBase<InstallerItem> implements Ve
                 InstallerItem installerItem = new InstallerItem(libraryId);
                 installerItem.libraryVersion.set(libraryVersion);
                 installerItem.installable.set(false);
-                installerItem.upgradable.bind(installerItem.installable);
+                installerItem.upgradable.set(false);
                 installerItem.removable.set(true);
                 installerItem.removeAction.set(e -> action.run());
 
-                if (libraryVersion != null && Lang.test(() -> profile.getDependency().getVersionList(libraryId))) {
-                    installerItem.installable.set(true);
-                    installerItem.action.set(e -> {
-                        Controllers.getDecorator().startWizard(new UpdateInstallerWizardProvider(profile, gameVersion, version, libraryId, libraryVersion));
-                    });
-                }
-
                 itemsProperty().add(installerItem);
             }
         }, Platform::runLater);
@@ -175,7 +169,8 @@ public class InstallerListPage extends ListPageBase<InstallerItem> implements Ve
         @Override
         protected List<Node> initializeToolbar(InstallerListPage skinnable) {
             return Collections.singletonList(
-                    createToolbarButton2(i18n("install.installer.install_offline"), SVG.PLUS, skinnable::installOffline));
+                    createToolbarButton2(i18n("install.installer.install_offline"), SVG.PLUS, skinnable::installOffline)
+            );
         }
     }
 }

HMCL/src/main/resources/assets/lang/I18N.properties

@@ -637,6 +637,7 @@ install.installer.optifine=OptiFine
 install.installer.quilt=Quilt
 install.installer.quilt-api=QSL/QFAPI
 install.installer.version=%s
+install.installer.external_version=%s Installed by external process, which cannot be configured
 install.modpack=Install a Modpack
 install.new_game=Add a New Instance
 install.new_game.already_exists=This instance already exists. Please use another name.

HMCL/src/main/resources/assets/lang/I18N_zh.properties

@@ -521,6 +521,7 @@ install.installer.optifine=OptiFine
 install.installer.quilt=Quilt
 install.installer.quilt-api=QSL/QFAPI
 install.installer.version=%s
+install.installer.external_version=%s 由外部安裝的版本，無法解除安裝或更換
 install.modpack=安裝模組包
 install.new_game=安裝新遊戲版本
 install.new_game.already_exists=此版本已經存在，請重新命名

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

@@ -520,6 +520,7 @@ install.installer.optifine=OptiFine
 install.installer.quilt=Quilt
 install.installer.quilt-api=QSL/QFAPI
 install.installer.version=%s
+install.installer.external_version=%s 由外部安装的版本，无法卸载或更换
 install.modpack=安装整合包
 install.new_game=安装新游戏版本
 install.new_game.already_exists=此版本已经存在，请换一个名字