From 8a4f6af193ab5f7cf94685552d9f4cc61bdd3b17 Mon Sep 17 00:00:00 2001 From: Haowei Wen Date: Sun, 29 Dec 2024 21:40:09 +0800 Subject: [PATCH] Fix NPE due to the order of attaching specificSettingsListener --- .../org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java index b756ec685..aab4a3c1a 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/VersionSettingsPage.java @@ -552,9 +552,9 @@ public final class VersionSettingsPage extends StackPane implements DecoratorPag FXUtils.bindEnum(cboLauncherVisibility, versionSetting.launcherVisibilityProperty()); FXUtils.bindEnum(cboProcessPriority, versionSetting.processPriorityProperty()); - versionSetting.usesGlobalProperty().addListener(specificSettingsListener); if (versionId != null) enableSpecificSettings.set(!versionSetting.isUsesGlobal()); + versionSetting.usesGlobalProperty().addListener(specificSettingsListener); javaItem.setToggleSelectedListener(newValue -> { if (javaItem.getSelectedData() == null || updatingSelectedJava)