lan/HMCL
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix getImplementationVersion returning null on Java 9.

Browse Source
This commit is contained in:
huanghongxun
2018-08-08 10:02:34 +08:00
parent 09730d74e0
commit a2b74b8e78
7 changed files with 123 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
HMCL/src/main/java/org/jackhuang/hmcl/Metadata.java
View File

@@ -17,7 +17,7 @@
*/
package org.jackhuang.hmcl;
import java.util.Optional;
import org.jackhuang.hmcl.util.JarUtils;
/**
* Stores metadata about this application.
@@ -25,7 +25,7 @@ import java.util.Optional;
public final class Metadata {
private Metadata() {}
public static final String VERSION = System.getProperty("hmcl.version.override", Optional.ofNullable(Metadata.class.getPackage().getImplementationVersion()).orElse("@develop@"));
public static final String VERSION = System.getProperty("hmcl.version.override", JarUtils.thisJar().flatMap(JarUtils::getImplementationVersion).orElse("@develop@"));
public static final String NAME = "HMCL";
public static final String TITLE = NAME + " " + VERSION;

24
HMCL/src/main/java/org/jackhuang/hmcl/upgrade/LocalRepository.java
View File

@@ -17,7 +17,11 @@
*/
package org.jackhuang.hmcl.upgrade;
import static org.jackhuang.hmcl.util.Logging.LOG;
import org.jackhuang.hmcl.Launcher;
import org.jackhuang.hmcl.task.FileDownloadTask;
import org.jackhuang.hmcl.util.JarUtils;
import org.tukaani.xz.XZInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.net.URL;
@@ -25,15 +29,11 @@ import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.Optional;
import java.util.jar.Attributes;
import java.util.jar.JarFile;
import java.util.jar.JarOutputStream;
import java.util.jar.Pack200;
import java.util.logging.Level;
import org.jackhuang.hmcl.Launcher;
import org.jackhuang.hmcl.task.FileDownloadTask;
import org.tukaani.xz.XZInputStream;
import static org.jackhuang.hmcl.util.Logging.LOG;
/**
* A class used to manage the local HMCL repository.
@@ -52,15 +52,9 @@ final class LocalRepository {
if (!Files.isRegularFile(localStorage)) {
return Optional.empty();
}
try (JarFile jar = new JarFile(localStorage.toFile())) {
Attributes attributes = jar.getManifest().getMainAttributes();
String version = Optional.ofNullable(attributes.getValue("Implementation-Version"))
.orElseThrow(() -> new IOException("Missing Implementation-Version"));
return Optional.of(new LocalVersion(version, localStorage));
} catch (IOException e) {
LOG.log(Level.WARNING, "Failed to read HMCL jar: " + localStorage, e);
return Optional.empty();
}
return Optional.of(localStorage)
.flatMap(JarUtils::getImplementationVersion)
.map(version -> new LocalVersion(version, localStorage));
}
private static void writeToStorage(Path source, boolean checkHeaders) throws IOException {

41
HMCL/src/main/java/org/jackhuang/hmcl/upgrade/LocalVersion.java
View File

@@ -17,47 +17,16 @@
*/
package org.jackhuang.hmcl.upgrade;
import static org.jackhuang.hmcl.util.Logging.LOG;
import java.net.URISyntaxException;
import java.net.URL;
import java.nio.file.FileSystemNotFoundException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.security.CodeSource;
import java.util.Optional;
import java.util.logging.Level;
import org.jackhuang.hmcl.Main;
import org.jackhuang.hmcl.Metadata;
import org.jackhuang.hmcl.util.JarUtils;
import java.nio.file.Path;
import java.util.Optional;
class LocalVersion {
public static Optional<LocalVersion> current() {
CodeSource codeSource = Main.class.getProtectionDomain().getCodeSource();
if (codeSource == null) {
return Optional.empty();
}
URL url = codeSource.getLocation();
if (url == null) {
return Optional.empty();
}
Path path;
try {
path = Paths.get(url.toURI());
} catch (FileSystemNotFoundException | IllegalArgumentException | URISyntaxException e) {
LOG.log(Level.WARNING, "Invalid path: " + url, e);
return Optional.empty();
}
if (!Files.isRegularFile(path)) {
return Optional.empty();
}
return Optional.of(new LocalVersion(Metadata.VERSION, path));
return JarUtils.thisJar().map(path -> new LocalVersion(Metadata.VERSION, path));
}
private String version;