From c7cc2d073359d576ead4f6f6ad85f72cf2b9e04c Mon Sep 17 00:00:00 2001 From: 3gf8jv4dv <3gf8jv4dv@gmail.com> Date: Mon, 11 Nov 2024 19:20:28 +0800 Subject: [PATCH] Fix missing i18n when checking for updates fails (#3444) * Fix missing i18n when checking for updates fails * Revise translation --- .../java/org/jackhuang/hmcl/ui/versions/ModListPage.java | 2 +- .../java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java | 2 +- HMCL/src/main/resources/assets/lang/I18N.properties | 5 +++-- HMCL/src/main/resources/assets/lang/I18N_es.properties | 3 ++- HMCL/src/main/resources/assets/lang/I18N_ja.properties | 3 ++- HMCL/src/main/resources/assets/lang/I18N_ru.properties | 3 ++- HMCL/src/main/resources/assets/lang/I18N_zh.properties | 3 ++- HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties | 3 ++- 8 files changed, 15 insertions(+), 9 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java index cdbb33350..5ce5eddbd 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java @@ -192,7 +192,7 @@ public final class ModListPage extends ListPageBase { if (exception != null || result == null) { - Controllers.dialog("Failed to check updates", "failed", MessageDialogPane.MessageType.ERROR); + Controllers.dialog(i18n("mods.check_updates.failed_check"), i18n("message.failed"), MessageDialogPane.MessageType.ERROR); } else if (result.isEmpty()) { Controllers.dialog(i18n("mods.check_updates.empty")); } else { diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java index 791ba21c4..fcd284104 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java @@ -139,7 +139,7 @@ public class ModUpdatesPage extends BorderPane implements DecoratorPage { task.whenComplete(Schedulers.javafx(), exception -> { fireEvent(new PageCloseEvent()); if (!task.getFailedMods().isEmpty()) { - Controllers.dialog(i18n("mods.check_updates.failed") + "\n" + + Controllers.dialog(i18n("mods.check_updates.failed_download") + "\n" + task.getFailedMods().stream().map(LocalModFile::getFileName).collect(Collectors.joining("\n")), i18n("install.failed"), MessageDialogPane.MessageType.ERROR); diff --git a/HMCL/src/main/resources/assets/lang/I18N.properties b/HMCL/src/main/resources/assets/lang/I18N.properties index afa765ec7..cdb2ba7c5 100644 --- a/HMCL/src/main/resources/assets/lang/I18N.properties +++ b/HMCL/src/main/resources/assets/lang/I18N.properties @@ -816,7 +816,7 @@ logwindow.export_dump.no_dependency=Your Java does not contain the dependencies main_page=Home -message.cancelled=Operation canceled +message.cancelled=Operation Canceled message.confirm=Confirm message.copied=Copied to clipboard message.default=Default @@ -985,7 +985,8 @@ mods.channel.release=Release mods.check_updates=Check for Updates mods.check_updates.current_version=Current Version mods.check_updates.empty=All mods are up-to-date -mods.check_updates.failed=Failed to download some files. +mods.check_updates.failed_check=Failed to check for updates. +mods.check_updates.failed_download=Failed to download some files. mods.check_updates.file=File mods.check_updates.source=Source mods.check_updates.target_version=Target Version diff --git a/HMCL/src/main/resources/assets/lang/I18N_es.properties b/HMCL/src/main/resources/assets/lang/I18N_es.properties index b2d6c5f9a..551a0c4dd 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_es.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_es.properties @@ -830,7 +830,8 @@ mods.add.success=%s fue instalado con éxito. mods.category=Categoría mods.check_updates=Comprobar actualizaciones mods.check_updates.current_version=Versión actual -mods.check_updates.failed=No se han podido descargar algunos de los archivos. +mods.check_updates.failed_check=No se ha podido comprobar si hay actualizaciones. +mods.check_updates.failed_download=No se han podido descargar algunos de los archivos. mods.check_updates.file=Archivo mods.check_updates.source=Fuente mods.check_updates.target_version=Versión de destino diff --git a/HMCL/src/main/resources/assets/lang/I18N_ja.properties b/HMCL/src/main/resources/assets/lang/I18N_ja.properties index 7a5d28b39..a630f26e8 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_ja.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_ja.properties @@ -665,7 +665,8 @@ mods.add.success=mods %s が正常に追加されました。 mods.category=Category mods.check_updates=更新を確認 mods.check_updates.current_version=Current -mods.check_updates.failed=一部のファイルのダウンロードに失敗しました +mods.check_updates.failed_check=更新のチェックに失敗しました +mods.check_updates.failed_download=一部のファイルのダウンロードに失敗しました mods.check_updates.file=ファイル mods.check_updates.source=Source mods.check_updates.target_version=Target diff --git a/HMCL/src/main/resources/assets/lang/I18N_ru.properties b/HMCL/src/main/resources/assets/lang/I18N_ru.properties index 9a6e59b4d..e0d58deb4 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_ru.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_ru.properties @@ -696,7 +696,8 @@ mods.add.success=%s был успешно установлен. mods.category=Категория mods.check_updates=Проверить обновления mods.check_updates.current_version=Текущая версия -mods.check_updates.failed=Не удаётся скачать некоторые файлы. +mods.check_updates.failed_check=Не удалось проверить обновления. +mods.check_updates.failed_download=Не удаётся скачать некоторые файлы. mods.check_updates.file=Файл mods.check_updates.source=Источник mods.check_updates.target_version=Целевая версия diff --git a/HMCL/src/main/resources/assets/lang/I18N_zh.properties b/HMCL/src/main/resources/assets/lang/I18N_zh.properties index f8ff29377..9cee9c787 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_zh.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_zh.properties @@ -790,7 +790,8 @@ mods.channel.release=Release mods.check_updates=檢查模組更新 mods.check_updates.current_version=目前版本 mods.check_updates.empty=沒有需要更新的模組 -mods.check_updates.failed=部分檔案下載失敗 +mods.check_updates.failed_check=檢查更新失敗 +mods.check_updates.failed_download=部分檔案下載失敗 mods.check_updates.file=檔案 mods.check_updates.source=來源 mods.check_updates.target_version=目標版本 diff --git a/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties b/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties index 0e7440269..c1f2d25f9 100644 --- a/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties +++ b/HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties @@ -801,7 +801,8 @@ mods.channel.release=稳定版本 mods.check_updates=检查模组更新 mods.check_updates.current_version=当前版本 mods.check_updates.empty=没有需要更新的模组 -mods.check_updates.failed=部分文件下载失败 +mods.check_updates.failed_check=检查更新失败 +mods.check_updates.failed_download=部分文件下载失败 mods.check_updates.file=文件 mods.check_updates.source=来源 mods.check_updates.target_version=目标版本