lan/JKVideo
1
0
Fork 0
mirror of https://gh-proxy.org/https://github.com/tiajinsha/JKVideo synced 2026-07-07 23:18:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs: finalize chunk 3 plan (import ordering, dependency note)

Browse Source
This commit is contained in:
Developer
2026-03-11 14:15:06 +08:00
parent 992c7a3a6a
commit e608dcc09a
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/superpowers/plans/2026-03-11-big-video-card.md
View File

@@ -358,13 +358,7 @@ const onViewableItemsChangedRef = useRef(
- [ ] **Step 4: Replace `renderItem` with a row-aware version and remove stale import**
After replacing `renderItem`, `VideoItem` is no longer directly referenced in `app/index.tsx`. Remove the now-unused import:
```ts
// Remove this line:
import type { VideoItem } from "../services/types";
```
Replace the existing `renderItem` function:
First, replace the existing `renderItem` function (keep the file valid at all times):
```ts
const renderItem = ({ item: row }: { item: ListRow }) => {
if (row.type === 'big') {
@@ -398,6 +392,12 @@ const renderItem = ({ item: row }: { item: ListRow }) => {
};
```
Then remove the now-unused import (check the file for any other references to `VideoItem` before deleting — if none found, remove it):
```ts
// Remove this line:
import type { VideoItem } from "../services/types";
```
- [ ] **Step 5: Update `styles.row` in the StyleSheet**
`styles.row` was previously used as `columnWrapperStyle` — FlatList automatically applies `flexDirection: 'row'` to column wrappers. Now that it becomes an explicit `<View style={styles.row}>`, `flexDirection: 'row'` must be added explicitly or the pair columns will stack vertically.
@@ -430,7 +430,7 @@ viewabilityConfig={VIEWABILITY_CONFIG}
onViewableItemsChanged={onViewableItemsChangedRef}
```
Note: `react-native-video` is already installed in this project (confirmed by `components/NativeVideoPlayer.tsx` which imports `Video` from it). No additional installation needed.
Note: `react-native-video` is already installed in this project. Confirmed: `components/NativeVideoPlayer.tsx` line 14 has `import Video, { VideoRef } from "react-native-video"`. No additional installation needed.
- [ ] **Step 7: TypeScript check**